Skip to content

🐛 OCPBUGS-55165 Permissions preflight error output fixes #1934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025

Conversation

trgeiger
Copy link
Contributor

@trgeiger trgeiger commented Apr 21, 2025

Description

This PR contains 2 changes:

  • Adds an errors.Join() to properly expand a list of errors that might include nil errors
  • Adds explicit rule examples to 2 of the test cases

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@trgeiger trgeiger requested a review from a team as a code owner April 21, 2025 17:06
Copy link

netlify bot commented Apr 21, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit d3edc3e
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/6807c31754c4cd00086a9fbe
😎 Deploy Preview https://deploy-preview-1934--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 21, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.91%. Comparing base (e529653) to head (d3edc3e).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
internal/operator-controller/authorization/rbac.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1934      +/-   ##
==========================================
- Coverage   66.01%   65.91%   -0.10%     
==========================================
  Files          70       70              
  Lines        6182     6182              
==========================================
- Hits         4081     4075       -6     
- Misses       1841     1845       +4     
- Partials      260      262       +2     
Flag Coverage Δ
e2e 45.09% <0.00%> (ø)
unit 55.12% <33.33%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bentito bentito changed the title ✨ Permissions preflight error output fixes 🐛 OCPBUGS-55165 Permissions preflight error output fixes Apr 21, 2025
@trgeiger trgeiger force-pushed the rbac-error-fixes branch 4 times, most recently from cbfabeb to 24928e4 Compare April 22, 2025 16:00
Copy link
Contributor

@bentito bentito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmshort tmshort added this pull request to the merge queue Apr 24, 2025
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems fine for me
Thank you for the nice work 🥇
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2025
Merged via the queue into operator-framework:main with commit a7ab445 Apr 24, 2025
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants